Minor suggestion

Having issues with the site, hardware, source code, or any other issues?

Moderator: robert.ghilduta

Post Reply
KE5FX
Posts: 7
Joined: Fri Aug 19, 2016 2:24 am

Minor suggestion

Post by KE5FX » Fri Aug 19, 2016 7:20 pm

Having your installer nuke everything in the target directory, including files the user placed there, is somewhat nonstandard in the Windows world, just FYI.

jynik
Posts: 455
Joined: Thu Jun 06, 2013 8:15 pm

Re: Minor suggestion

Post by jynik » Mon Aug 22, 2016 12:50 pm

Thanks for the heads up!

Could you elaborate on which files of yours where removed and where they resided, just so that we can consider than when looking at the uninstall logic? I know that usually some MATLAB-generated files from the install will get left behind -- I'm wondering if trying to clean those up is what is overzealous...

KE5FX
Posts: 7
Joined: Fri Aug 19, 2016 2:24 am

Re: Minor suggestion

Post by KE5FX » Wed Aug 24, 2016 11:18 pm

jynik wrote:Thanks for the heads up!

Could you elaborate on which files of yours where removed and where they resided, just so that we can consider than when looking at the uninstall logic? I know that usually some MATLAB-generated files from the install will get left behind -- I'm wondering if trying to clean those up is what is overzealous...
In this particular case, one or two .bat files that I wrote to use as shortcuts for bladerf-cli.exe went away. They had filenames like t.bat.

The usual practice for Windows installers is to remove nothing except the files that they put there. There are exceptions here and there but they're tough to justify, IMHO.

BTW, should I have a bladerf_winflasher.exe anywhere? The Wiki mentions it at https://github.com/Nuand/bladeRF/wiki/U ... F-firmware but I don't see it anywhere in the current Windows distro.

jynik
Posts: 455
Joined: Thu Jun 06, 2013 8:15 pm

Re: Minor suggestion

Post by jynik » Thu Aug 25, 2016 10:13 am

Hi KE5FX,

Thanks for sharing your use-case. The installer framework is supposed to operate as you described to be the de facto standard... provided one only lists files themselves as uninstall targets. Based on the behavior you describe, it must be that we have an entire directory listed...

Do you recall which directory the shortcuts were in? That might help track down the overzealous uninstall target...

That bladerf_winflasher.exe hasn't existed in quite some time -- I will fix the wiki to remove that. It was removed because the bladeRF-cli already has the ability to flash firmware.

KE5FX
Posts: 7
Joined: Fri Aug 19, 2016 2:24 am

Re: Minor suggestion

Post by KE5FX » Thu Aug 25, 2016 8:59 pm

jynik wrote:Do you recall which directory the shortcuts were in? That might help track down the overzealous uninstall target...
In this case I'd installed it to c:\dev\bladerf and put my batch files in the x64 subdirectory, alongside the various executables.

jynik
Posts: 455
Joined: Thu Jun 06, 2013 8:15 pm

Re: Minor suggestion

Post by jynik » Fri Aug 26, 2016 9:13 am

Thanks -- will add that to the TODO list for furture revs.

By the way -- fantastic work on the GPIB toolkit! (Thought that callsign looked familiar... ;) )

KE5FX
Posts: 7
Joined: Fri Aug 19, 2016 2:24 am

Re: Minor suggestion

Post by KE5FX » Fri Aug 26, 2016 2:18 pm

jynik wrote:Thanks -- will add that to the TODO list for furture revs.

By the way -- fantastic work on the GPIB toolkit! (Thought that callsign looked familiar... ;) )
Thanks! It's an amusing collection of hacks, all right.

I've had this board since your original Kickstarter campaign, but have only just now started to play with it. Complaints about MIA batch files notwithstanding, I've really been impressed at how accessible and readable/modifiable your code and HDL is. bladerf-cli is great in particular -- it's rare to see SDR projects based on simple platform-independent console apps instead of layers of weird scripts and "innovative" GUIs with homebrew flow graphs or whatever. It's almost like an honorary GPIB Toolkit component. 8-)

I also have a couple of other questions, will start another thread for them.

KE5FX
Posts: 7
Joined: Fri Aug 19, 2016 2:24 am

Re: Minor suggestion

Post by KE5FX » Fri Sep 02, 2016 12:19 pm

Any thoughts on this? I may have asked in the wrong section.

Post Reply